[Bug 765275] matroska: implement reading & writing ContentEncryption headers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765275

--- Comment #30 from y.bandou <bandou.yacine at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #26)
> Review of attachment 361954 [details] [review]:
> 
> ::: gst/matroska/matroska-mux.c
> @@ +1051,3 @@
> +
> +  gst_structure_get_enum (structure, "signature-algorithm",
> +      MATROSKA_TRACK_SIGNATURE_ALGORITHM_TYPE, &signature_algorithm);
> 
> Shouldn't encrypted content get its own caps type(s)? This looks now like it
> supports the existing ones with additional fields, but using the existing
> ones is wrong: the content is encrypted and unusable without previous
> decryption
> 
> In the demuxer you use a new caps type: "application/x-matroska-enc"
> 
Yes indeed,

By looking closely matroskamux it is not possible to mux an encrypted contents,
as you indicated.
I'll remove all encrypted content support from matroskamux.

I'll only submit the encrypted content support in matroskademux like is done in
qtdemux (qtmux doesn't support encrypted content)

What do you think?

> @@ +2334,3 @@
> +    enc.sig_algo = signature_algorithm;
> +
> +    g_array_append_val (context->encodings, enc);
> 
> This code seems to be duplicated for each pad type, maybe move it to a
> function?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.