[Bug 765275] matroska: implement reading & writing ContentEncryption headers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765275

--- Comment #32 from y.bandou <bandou.yacine at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #31)
> (In reply to y.bandou from comment #30)
> > (In reply to Sebastian Dröge (slomo) from comment #26)
> > > Review of attachment 361954 [details] [review] [review] [review]:
> > > 
> > > ::: gst/matroska/matroska-mux.c
> > > @@ +1051,3 @@
> > > +
> > > +  gst_structure_get_enum (structure, "signature-algorithm",
> > > +      MATROSKA_TRACK_SIGNATURE_ALGORITHM_TYPE, &signature_algorithm);
> > > 
> > > Shouldn't encrypted content get its own caps type(s)? This looks now like it
> > > supports the existing ones with additional fields, but using the existing
> > > ones is wrong: the content is encrypted and unusable without previous
> > > decryption
> > > 
> > > In the demuxer you use a new caps type: "application/x-matroska-enc"
> > > 
> > Yes indeed,
> > 
> > By looking closely matroskamux it is not possible to mux an encrypted
> > contents, as you indicated.
> > I'll remove all encrypted content support from matroskamux.
> 
> Why is it impossible?

It's very difficult with encrypted content because sometimes we need to read
data as for the Dirac codec. see this function
"gst_matroska_mux_handle_dirac_packet".

> 
> > I'll only submit the encrypted content support in matroskademux like is done
> > in qtdemux (qtmux doesn't support encrypted content)
> > 
> > What do you think?
> 
> Sounds ok

Perfect, I'll submit a new patches to add support of encrypted content just in
matroskademux without matroskamux and of course with your new remarks.

I should change the summary of this bug ? 

"matroska: implement reading & writing ContentEncryption headers" -> "matroska:
Add encrypted content support in matroskademux"

Or I'll create a new bug?

What do you think ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.