[Bug 789763] appsink: test_query_drain unit test is racy

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789763

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #364623|none                        |committed
             status|                            |

--- Comment #4 from Julien Isorce <julien.isorce at gmail.com> ---
Comment on attachment 364623
  --> https://bugzilla.gnome.org/attachment.cgi?id=364623
appsink: fix end condition of query drain handler

commit 8af7b1f70b554ec25025a8c08c9f0dd14954923c
Author: Julien Isorce <jisorce at oblong.com>
Date:   Wed Nov 29 14:53:57 2017 +0000

    appsink: fix end condition of query drain handler

    The while loop should end when all buffers "and" the preroll
    buffer are consumed but this means to continue waiting if there
    are still some pending buffers "or" preroll buffer.

    The unit test was correct but racy because of this mistake.
    I.e. because of the wrong "and" the while could finish too early.

    cd tests/check && GST_CHECKS=test_query_drain make elements/appsink.forever

    https://bugzilla.gnome.org/show_bug.cgi?id=789763

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.