[Bug 730758] tee: Handle ALLOCATION query

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=730758

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #360772|none                        |needs-work
             status|                            |

--- Comment #37 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 360772:
 --> (https://bugzilla.gnome.org/review?bug=730758&attachment=360772)

That's a good catch, it's an unwanted side effect. I would probably suggest
adding explicit mark, e.g. param_found/pool_found since some Opaque format may
use 0 for pool size (in fact I have no idea, but explicit marker seems safer).

::: plugins/elements/gsttee.c
@@ +800,3 @@
+        /* If size==0, buffers would have no memory. */
+        if (ctx.size > 0) {
+          gst_query_add_allocation_param (ctx.query, NULL, &ctx.params);

That's incorrect, we should have a specific mark to know if we didn't find any
allocation params.

@@ +802,3 @@
+          gst_query_add_allocation_param (ctx.query, NULL, &ctx.params);
+          gst_query_add_allocation_pool (ctx.query, NULL, ctx.size,
+              ctx.min_buffers, 0);

That's correct, indeed we should not introduce a allocation_pool if there was
none-downstream.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.