[Bug 765275] matroska: implement reading & writing ContentEncryption headers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765275

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #354560|none                        |needs-work
             status|                            |

--- Comment #18 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 354560:
 --> (https://bugzilla.gnome.org/review?bug=765275&attachment=354560)

This needs some general documentation about how the stream is stored in
buffers, what is sent via GstMetas and events, what goes into caps, etc. and
how this maps to the Matroska/WebM spec.

Otherwise this looks generally OK to me.

::: gst/matroska/matroska-mux.c
@@ +2265,3 @@
+
+    enc.scope = GST_MATROSKA_TRACK_ENCODING_SCOPE_FRAME;
+    enc.type = GST_MATROSKA_ENCODING_ENCRYPTION;

The scope and type should probably also go into the caps so we can extend it
later

@@ +2267,3 @@
+    enc.type = GST_MATROSKA_ENCODING_ENCRYPTION;
+    enc.enc_algo = content_encryption ? 5 : 0;
+    enc.sig_algo = content_signing ? 1 : 0;

And these should probably map to something more expressive than booleans in the
caps to allow for different algos in the future

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.