[Bug 765275] matroska: implement reading & writing ContentEncryption headers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765275

--- Comment #22 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to y.bandou from comment #21)
> > @@ +2970,3 @@
> > +                GST_WARNING_OBJECT (common->sinkpad,
> > +                    "Unexpected to have ContentEncAESSettings because
> > Content Encryption Algo different to 5-AES");
> > +                ret = gst_ebml_read_skip (ebml);
> > 
> > We can probably still parse that and output the encrypted stream, just that
> > downstream will have an unsupported enc algo in the caps and can't handle
> > it. Unless it can handle something else than AES. Or not?
> 
> The Webm support only AES algorithm.
> 
> The spec: https://www.webmproject.org/docs/container/
> 
> The encryption algorithm used. The value '0' means that the contents have
> not been encrypted but only signed. Predefined values: 1 - DES; 2 - 3DES; 3
> - Twofish; 4 - Blowfish; 5 - AES. WebM only supports a value of 5 (AES).

Right, but there's no reason to error out if a different value is found. We
could still put it in the caps, and there just won't be a decryptor found then
that can handle it. Also for non-WebM all the other values are still valid.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.