[Bug 788550] New: g_assert_not_reached called incorrectly in function handle_queued_objects

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=788550

            Bug ID: 788550
           Summary: g_assert_not_reached called incorrectly in function
                    handle_queued_objects
    Classification: Platform
           Product: GStreamer
           Version: 1.12.3
                OS: All
            Status: NEW
          Severity: minor
          Priority: Normal
         Component: gst-omx
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: kr.ashish at samsung.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

In 
File : testegl.c
Function : static gboolean handle_queued_objects (APP_STATE_T * state)
Line No. 942

g_assert_not_reached in correctly called in both if and else clauses

----------------------
      if (gst_structure_has_name (s, "not-used")) {
        g_assert_not_reached ();
      } else {
        g_assert_not_reached ();
      }
---------------------

as g_assert_not_reached()is a debugging macro to terminate the application if
it is ever reached. If it is reached, an error message is logged and the
application is terminated.


Solution : 
else clause should be removed

- else {
-        g_assert_not_reached ();
-      }

Please let me know if I can submit a patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.