[Bug 788567] opencv: Add support for blurring portion of image

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=788567

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #361195|none                        |needs-work
             status|                            |

--- Comment #2 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 361195:
 --> (https://bugzilla.gnome.org/review?bug=788567&attachment=361195)

It looks generally good, but I think we should rather have absolute values
instead of relative to the frame size, for precision and because it is what we
usually do, have a look at GstCompositorPad, although in gdkpixbufoverlay we
have a switch to let users use relative values for the positioning, not the
size though.

I think we could merge with relative values for x/y if you rename so that we
can extend the API later and have it similar to other ones (ie
gdkpixbufoverlay).

::: ext/opencv/gstcvsmooth.h
@@ -76,0 +76,6 @@
+
+  /* coordinates to apply the effect to, 0..1 relative to image size */
+  gdouble positionx;
... 3 more ...

Those should be called width/height to follow usual GStreamer namings

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.