[Bug 788838] [Fix for]Possible crash due to dereferencing a null pointer in gst_queue_array_is_empty

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Oct 11 16:48:03 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=788838

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #361342|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 361342:
 --> (https://bugzilla.gnome.org/review?bug=788838&attachment=361342)

::: gstreamer-1.12.3_org/libs/gst/base/gstqueuearray.c
@@ +318,3 @@
 gst_queue_array_is_empty (GstQueueArray * array)
 {
+  return (!array || array->length == 0);

It's a programming error to pass NULL here.

Use "g_return_val_if_fail (array != NULL, FALSE);"

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list