[Bug 762884] rtspsrc: allow to control headers via properties

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=762884

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #344659|none                        |needs-work
             status|                            |

--- Comment #29 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 344659:
 --> (https://bugzilla.gnome.org/review?bug=762884&attachment=344659)

Looks good generally

::: gst/rtsp/gstrtspsrc.c
@@ +431,3 @@
+
+  myboolean = g_value_get_boolean (handler_return);
+  GST_DEBUG ("accum %d", myboolean);

This is not very descriptive :) Please output something more meaningful

@@ +5379,3 @@
+  if (!allow_send) {
+    GST_DEBUG_OBJECT (src, "skipping message, disabled by signal");
+    return GST_RTSP_OK;

Or maybe it should also be possible to make it an error?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.