[Bug 788979] New: "format" parameter in gstsegment.c as unused

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=788979

            Bug ID: 788979
           Summary: "format" parameter in gstsegment.c as unused
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gstreamer (core)
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: ensonic at sonicpulse.de
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Most of the methods in gstsegment.c take these parameters:
GstSegment * segment; /* a #GstSegment structure. */
GstFormat format;     /* the format of the segment. */

What puzzles me is that most (but not all methods) do

   g_return_val_if_fail (segment->format == format, FALSE);

and thats the only use of the format parameter (except passing it to other
methods in the same module).

What about:
1.) marking all those 'format' args in the docs as 'unused' and
    G_GNUC_UNUSED on the declaration.
2.) removing all the g_return_val_if_fail() checks
3.) adding a 'FIXME: 2.0' to drop the parameter

I'll post a patch later.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.