[Bug 777213] hlsdemux: Re-expose only variant stream with bitrate switching

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Oct 16 02:00:48 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=777213

--- Comment #10 from tianyahai <490202531 at qq.com> ---
(In reply to Seungha Yang from comment #9)
> (In reply to tianyahai from comment #7)
> > Hi, how about subtitle streams, now my m3u8 file has eight subtitles, it can
> > be displayed by playbin, but when i switch to another, the subtitle
> > disappeared, why?
> 
> AFAIK, subtitle is disabled in current hlsdemux. Need more context such as
> your m3u8 and your playbin usecase (playbin or playbin3).
> 
> 
Thank you for your reply, in deeded, the subtitles are closed by default, but
in the code of gsthlsdemux.c file i enabled subtitle like this:
  select = demux->streams_aware ? TRUE : (media->mtype ==
GST_HLS_MEDIA_TYPE_VIDEO ||
          media->mtype == GST_HLS_MEDIA_TYPE_AUDIO || media->mtype ==
GST_HLS_MEDIA_TYPE_SUBTITLES);

In my m3u8 there are eight subtitles, the subtitles can be displayed when the
code is running, but if i switch subtitle to another it will be disappear, i
used playbin or playbin2, not playbin3

> (In reply to tianyahai from comment #8)
> > what's the meaning of GST_BIN_FLAG_STREAMS_AWARE? 
> > I added GST_BIN_FLAG_STREAMS_AWARE to the code refer according to your
> > method, but the value of demux->streams_aware is FALSE, when the code is
> > running
> 
> You can refer to its meaning at
> https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/
> GstBin.html
> My understanding about it is that, it's used in playbin3 (not playbin) to
> indicate that corresponding element/bin can handle GstStreams API and also
> can handle stream add/removal during playback without any interruption.
> 
> I guess you are now use playbin (not playbin3). The playbin doesn't use
> urisourcebin but do uridecodebin. Please not that my patch aims to set the
> flag at urisourcebin and read it by adaptivedemux (this is urisourcebin's
> child bin)

Yes,as you say,i used playbin,can i add "GST_OBJECT_FLAG_SET (dec,
GST_ELEMENT_FLAG_SOURCE | GST_BIN_FLAG_STREAMS_AWARE)" to gsturidecodebin.c
file according to your urisourcebin file? 
How can hlsdemux achieve switch subtitles...

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list