[Bug 777213] hlsdemux: Re-expose only variant stream with bitrate switching

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Oct 16 03:19:08 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=777213

--- Comment #13 from Seungha Yang <seungha.yang at navercorp.com> ---
(In reply to tianyahai from comment #10)
> Thank you for your reply, in deeded, the subtitles are closed by default,
> but in the code of gsthlsdemux.c file i enabled subtitle like this:
>   select = demux->streams_aware ? TRUE : (media->mtype ==
> GST_HLS_MEDIA_TYPE_VIDEO ||
>           media->mtype == GST_HLS_MEDIA_TYPE_AUDIO || media->mtype ==
> GST_HLS_MEDIA_TYPE_SUBTITLES);
> 
> In my m3u8 there are eight subtitles, the subtitles can be displayed when
> the code is running, but if i switch subtitle to another it will be
> disappear, i used playbin or playbin2, not playbin3
This comment might be helpful for you :)
https://bugzilla.gnome.org/show_bug.cgi?id=779011#c7

> Yes,as you say,i used playbin,can i add "GST_OBJECT_FLAG_SET (dec,
> GST_ELEMENT_FLAG_SOURCE | GST_BIN_FLAG_STREAMS_AWARE)" to gsturidecodebin.c
> file according to your urisourcebin file? 
You can try it but it doesn't make sense because uridecodebin doesn't
"STREAMS_AWARE".

> How can hlsdemux achieve switch subtitles...
It's totally dependent on adaptivdemux's track switch method. Firstly,
adaptivdemux(hlsdemux) will expose all available tracks during preroll state.
Then, stop streaming for non-activated track depending on flow return
"not-linked". It's well described on comment of gstadaptivedemux.c

Then, if you try switch track, it will trigger "reconfigure" event which also
trigger re-streaming for newly activated track in adaptivedemux. Basically,
this is how adaptivedemux switch tracks. But when I saw comment above, there
seems weak point (maybe bug?) in playbin's subtitle track change behavior.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list