[Bug 788763] dashdemux: segmentbase type with 'sidx' is not working as expected.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=788763

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #361232|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 361232:
 --> (https://bugzilla.gnome.org/review?bug=788763&attachment=361232)

::: ext/dash/gstdashdemux.c
@@ +1354,3 @@
         dashstream->actual_position += entry->duration;
       } else {
+        stream->fragment.range_end = stream->fragment.range_start +
entry->size - 1;

This is wrong. The range request should only be until the end of the current
SIDX entry, not until the end of the fragment.

@@ +2961,3 @@
         if (dash_stream->sidx_parser.status == GST_ISOFF_SIDX_PARSER_FINISHED
&&
+            (SIDX (dash_stream)->entry_index != 0) ||
(!stream->downloading_index) &&
+            ref_type1_found == FALSE) {

The parser status should be not FINISHED already if a ref_type of 1 was found.
Is it not?

::: gst-libs/gst/adaptivedemux/gstadaptivedemux.c
@@ +3297,3 @@
           stream->fragment.index_range_end, NULL);
+      
+      gst_adaptive_demux_stream_update_fragment_info(stream->demux, stream);

Why is this needed exactly, what are the events that have to happen for this to
be required?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.