[Bug 710324] encodebin: Implement subtitles support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=710324

Mathieu Duponchelle <mduponchelle1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #277234|none                        |reviewed
             status|                            |

--- Comment #12 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Review of attachment 277234:
 --> (https://bugzilla.gnome.org/review?bug=710324&attachment=277234)

You'll also want to update win32/common/libgstpbutils.def

::: gst-libs/gst/pbutils/encoding-profile.c
@@ +915,3 @@
+ * Creates a new #GstEncodingSubtitleProfile
+ *
+ * All provided allocatable arguments will be internally copied, so can be

We don't usually say this, as annotations are exposed in the documentation

::: gst-libs/gst/pbutils/encoding-profile.h
@@ +98,3 @@

+/**
+ * GstEncodingSubtitleProfile:

Why call it "subtitle" profile and not "text" ? "text" seems a bit more
agnostic to me :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.