[Bug 739010] [PLUGIN MOVE] Move GstAggregator to gstreamer (core)

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=739010

Mathieu Duponchelle <mduponchelle1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mduponchelle1 at gmail.com

--- Comment #44 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
I just gave a quick look at gstaggregator.h, and one point that I think needs
discussing is whether we want subclasses to iterate sink pads through
GstElement.sinkpads, or through some other mechanism. There is already a
poorly-named foreach function for this purpose, gst_aggregator_iterate_sinkpads
, with an associated FIXME:

/* API that should eventually land in GstElement itself (FIXME) */

Requiring subclasses to only aggregate pads explicitly listed as "aggregatable"
could give us in the future the ability to exclude pads from aggregation for
one reason or another, and could also simplify implementation, as the subclass
would for example not need, as currently, to check whether a pad did have a
buffer.

If we require that, we need to rename gst_aggregator_iterate_sinkpads to
gst_aggregator_foreach_sinkpad, and provide an actual iterate function for the
pads to aggregate.

If not, we will probably want to implement and expose a proper
gst_element_foreach_pad method.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.