[Bug 788340] Dynamically reconfigure pipeline in PLAY based on transports

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Oct 17 07:38:36 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=788340

--- Comment #3 from Patricia Muscalu <patricia at axis.com> ---
> Why are you adding the receiver/sender parts after PLAY and not during
> SETUP? SETUP is basically when the client tells the server to set up these
> pieces.
> In PLAY/RECORD you would only finish the setup and consider the session
> complete
> 

We presented/suggested this solution in our earlier mail conversation with you.
We do not need any pipeline in SETUP anyway. Let us know if you want us to
change this approach and complete the pipeline in SETUP.

> ::: gst/rtsp-server/rtsp-media.c
> @@ -595,2 @@
>    if (gst_rtsp_stream_query_position (stream, &tmp)) {
> -    data->position = MAX (data->position, tmp);
> 
> The part about the position reporting could probably be a separate commit

Yes, you are right. The change is included now in
0001-rtsp-media-return-minimum-value-in-query-position-ca.patch
> 
> @@ +611,3 @@
>    priv = media->priv;
>  
> +  data.position = G_MAXINT64;
> 
> Why this change? Generally, -1 is returned (GST_CLOCK_TIME_NONE) if nothing
> else can be found

GST_CLOCK_TIME_NONE is not a proper initial value because we are actually using
MIN function now.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list