[Bug 765927] new plugin: ICC (International Color Consortium) correction plugin

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765927

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #330494|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 330494:
 --> (https://bugzilla.gnome.org/review?bug=765927&attachment=330494)

::: ext/libpng/gstpngdec.c
@@ +356,3 @@
+        &icc_compression_type, &icc_profile, &icc_proflen);
+
+    if (ret & PNG_INFO_iCCP) {

Put this into double parenthesis, some compilers complain otherwise

@@ +358,3 @@
+    if (ret & PNG_INFO_iCCP) {
+      gpointer gst_icc_prof = g_memdup (icc_profile, icc_proflen);
+      if (gst_icc_prof != NULL) {

This will never be NULL

@@ +375,3 @@
+
+        if (icc_name)
+          gst_structure_set (info, "icc_name", G_TYPE_STRING, icc_name, NULL);

We usually use dash and not underscore as separator

@@ +388,3 @@
+
+        tag_event = gst_event_new_tag (gst_tag_list_copy (taglist));
+        gst_pad_push_event (GST_VIDEO_DECODER_SRC_PAD (pngdec), tag_event);

gst_video_decoder_merge_tags() would be better than manual tags handling here.
Also for any other tags handling pngdec might already do.

You're otherwise here currently overriding any other tags with yours.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.