[Bug 788918] vaapi: supports hierarchical prediction encoding

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=788918

--- Comment #25 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #14)
> Review of attachment 361492 [details] [review]:
> 
> ::: gst-libs/gst/vaapi/gstvaapiencoder_h264.c
> @@ +2852,3 @@
> +    reorder_pool->prev_frame_is_ref = TRUE;
> +  else
> +    reorder_pool->prev_frame_is_ref = FALSE;
> 
> this would be simpler as
> 
> reorder_pool->prev_frame_is_ref = GST_VAAPI_ENC_PICTURE_IS_REFRENCE
> (picture);
> 
> or even better
> 
> reorder_pool->prev_frame_is_ref = GST_VAAPI_ENC_PICTURE_IS_REFRENCE
> (picture) || GST_VAAPI_ENC_PICTURE_IS_IDR (picture);
> 
> removing the up assignation

Thanks for simpler suggesion. I think GST_VAAPI_ENC_PICTURE_IS_IDR is not
necessary to see if it's reference or not since it should be set if it's IDR
picture beforehand. I modified according to your first suggession.:)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.