[Bug 785679] element: add gst_element_foreach_*pad()

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785679

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #356714|none                        |reviewed
             status|                            |

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 356714:
 --> (https://bugzilla.gnome.org/review?bug=785679&attachment=356714)

Looks generally good to me

::: gst/gstelement.c
@@ +1296,3 @@
+ * iterating pads and return early. If new sink pads are added or sink pads
+ * are removed while the sink pads are being iterated, this will not be taken
+ * into account until next time this function is used.

This last sentence should be put in a warning block or similar :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.