[Bug 789384] glimagesink windows on wayland are created with a fixed window size of 320x240

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789384

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #362145|none                        |needs-work
             status|                            |

--- Comment #2 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 362145:
 --> (https://bugzilla.gnome.org/review?bug=789384&attachment=362145)

This would break the set_render_rectangle() use case.

The order for chosen sizes is:
1. set_render_rectangle()
2. preferred size
3. some default fallback

This patch essentially removes 1) from ever happening.

::: gst-libs/gst/gl/wayland/gstglwindow_wayland_egl.c
@@ +306,3 @@

+  if (window_egl->window.preffered_width > 0)
+    width = window_egl->window.preffered_width;

s/preffered/preferred/

@@ -304,3 @@

-  if (window_egl->window.window_width > 0)
-    width = window_egl->window.window_width;

This cannot just be removed as it's also used for the set_render_rectangle()
case.

@@ +312,3 @@

+  if (window_egl->window.preffered_height > 0)
+    height = window_egl->window.preffered_height;

s/preffered/preferred/

@@ +582,3 @@
+  window_egl->window.preffered_height = height;
+  if (window_egl->window.window_height != height ||
window_egl->window.window_width != width) {
+    window_resize (window_egl, width, height);

Is this call really necessary?  This would also prefer the preferred size
rather than a possible set_render_rectangle() size which is not correct.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.