[Bug 789403] avwait: Added end-timecode property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789403

--- Comment #3 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Thanks for the review! :)

(In reply to Mathieu Duponchelle from comment #2)
>
> ::: gst/timecode/gstavwait.c
> @@ -385,0 +417,22 @@
> +      if (self->end_tc
> +          && gst_video_time_code_compare (self->tc, self->end_tc) != -1) {
> +        gchar *start_tc, *end_tc;
> ... 19 more ...
> 
> copy paste issue ? :)

Not really :) There is the same check but slightly different actions that have
to be taken in three different places:

1) we provide start-timecode as string and it turns out to be after the
end-timecode: don't bother stringifying the start timecode, reject it (I'd say,
not bother creating it at the first place either - will update the patch)

2) we provide start-timecode as an object and it turns out to be after the
end-timecode: stringify both, reject start-timecode

3) we provide end-timecode as an object and it turns out to be after the
start-timecode: stringify both, reject end-timecode

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.