[Bug 789467] videoencoder: add qos property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789467

Mathieu Duponchelle <mduponchelle1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #362244|none                        |reviewed
             status|                            |

--- Comment #2 from Mathieu Duponchelle <mduponchelle1 at gmail.com> ---
Review of attachment 362244:
 --> (https://bugzilla.gnome.org/review?bug=789467&attachment=362244)

Looks good to me apart from that :)

::: gst-libs/gst/video/gstvideoencoder.c
@@ +174,2 @@
   /* QoS properties */
+  gint qos_enabled;             /* ATOMIC */

Hm, why not just protect with the object lock as well? It's taken right next to
where you check the variable already, just need to protect  the getters /
setters

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.