[Bug 789475] omx: wait for flush complete and buffers being released when flushing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789475

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |nicolas at ndufresne.ca

--- Comment #8 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
just before merging, I'd like some feedback. I've read the spec a little, and
receiving the command complete event before the buffers has been returns seems
like it would be a component bug. And then if you unblock when all buffers
comes back, and you didn't get the command complete, you'll endup with the
flushed boolean left set.

Overall, the patch makes things safer and more correct, but my impression is
that you should only wait for the command complete (flushed boolean), and warn
or error out if buffers where not returned by the component properly. Please
provide some feedback so I we don't merge this in the wrong form.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.