[Bug 789358] [Gst-plugins-base] [Memory Leak] Memory not freed in failure case in function gst_playback_utils_get_n_common_capsfeatures

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789358

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #362112|none                        |needs-work
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 362112:
 --> (https://bugzilla.gnome.org/review?bug=789358&attachment=362112)

Somehow seems to make sense, but I didn't go further since there is issues in
the submission.

- Patches should be against git master
- Title in this case should be in the form "playback-utils: Fix memory leak on
failure"

::: gst-plugins-base-1.12.3/gst/playback/gstplaybackutils.c
@@ +84,3 @@
     GST_ERROR ("Failed to get template caps from decoder or sink");
+    if (fact1_tmpl_caps) gst_caps_unref (fact1_tmpl_caps);
+    else if (fact2_tmpl_caps) gst_caps_unref (fact2_tmpl_caps);

Wrong coding style, you need to place the unref on the following line, with 2
space indentation.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.