[Bug 789700] gstvalue: Cast GST_MAKE_FOURCC arguments

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=789700

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #362613|none                        |reviewed
             status|                            |

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 362613
  --> https://bugzilla.gnome.org/attachment.cgi?id=362613
gstvalue: Cast GST_MAKE_FOURCC arguments

>+#define GST_MAKE_FOURCC(a,b,c,d) \
>+  ( (guint32)(a) | (guint32) ((b) << 8)  | (guint32) ((c) << 16) | (guint32) ((d) << 24))

Is this really what you want, rather than e.g.

  (((guint32)(b)) << 8)

etc. ? (i.e. cast go guint32 before shifting)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.