[Bug 788917] rtspsrc: Handling RTSP messages for debugging

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=788917

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #362592|none                        |needs-work
             status|                            |
 Attachment #362592|none                        |needs-work
             status|                            |

--- Comment #25 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 362592:
 --> (https://bugzilla.gnome.org/review?bug=788917&attachment=362592)

Looks mostly good, thanks :)

::: gst/rtsp/gstrtspsrc.c
@@ +470,1 @@
           DEFAULT_DEBUG, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

Let's deprecate this one now and always add it to the log. TRACE or LOG

Check threshold of the category before doing so

--- Comment #26 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 362592:
 --> (https://bugzilla.gnome.org/review?bug=788917&attachment=362592)

Looks mostly good, thanks :)

::: gst/rtsp/gstrtspsrc.c
@@ +470,1 @@
           DEFAULT_DEBUG, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

Let's deprecate this one now and always add it to the log. TRACE or LOG

Check threshold of the category before doing so

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.