[Bug 788006] audiobasesink: Fix clock skew adjustments
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Oct 31 17:00:39 UTC 2017
https://bugzilla.gnome.org/show_bug.cgi?id=788006
Sebastian Dröge (slomo) <slomo at coaxion.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #360213|none |needs-work
status| |
--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 360213:
--> (https://bugzilla.gnome.org/review?bug=788006&attachment=360213)
Please fix the commit message :) You don't "fix" the skew correction, but you
improve it so that it doesn't over-compensate.
Also please add some comments to the code to explain why you do those
calculations there and what the result is (how do we correct, where do we end
up?).
The idea makes sense in any case.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list