[Bug 730758] tee: Handle ALLOCATION query

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=730758

--- Comment #13 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
(In reply to Guillaume Desmottes from comment #11)
> Review of attachment 357284 [details] [review]:
> 
> ::: plugins/elements/gsttee.c
> @@ +592,3 @@
> +  gst_query_parse_allocation (ctx->query, &caps, NULL);
> +
> + * allocation would otherwise make dynamic pipelines much more complicated
> as
> 
> Shouldn't we pass the need_pool from ctx->query as well?
> Currently by always passing need_pool=FALSE kmssink doesn't return its
> buffers requirements, see
> https://cgit.freedesktop.org/gstreamer/gst-plugins-bad/tree/sys/kms/
> gstkmssink.c#n979

Good point. It still a waste to create the pool downstream, maybe we should
just fix sinks to set a NULL pool with their requirement if need-pool is FALSE
?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.