[Bug 787306] rtsp-sink : Fix Memory leak in gstrtspclientsink.c

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787306

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #359256|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 359256:
 --> (https://bugzilla.gnome.org/review?bug=787306&attachment=359256)

::: gst/rtsp-sink/gstrtspclientsink.c
@@ +3762,3 @@
+              TRUE);
+          gst_object_unref (context->stream_transport);
+          context->stream_transport = NULL;

This makes no sense:
a) context->stream_transport is always not NULL here
b) You first activate the stream transport, then unref and set it to NULL.
Basically destroying the stream transport right after activating it

Do you have a testcase to reproduce this memory leak? I would expect that test
case to fail in worse ways than a memory leak with that patch.

Also you said that the transport (not stream_transport) is leaked, or rather
the string inside it. That would have to be freed as part of the transport
then.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.