[Bug 787358] debugutils: Added new jitterer element

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787358

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #359260|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 359260:
 --> (https://bugzilla.gnome.org/review?bug=787358&attachment=359260)

I think this element is useful and different enough from netsim. It has a
different use case

::: gst/debugutils/gstjitterer.c
@@ +119,3 @@
+          "Average of the drift to apply",
+          -G_MAXINT64 / 2, G_MAXINT64 / 2, 0,
+          G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));

This is drift per buffer, which seems a bit difficult to control. Better would
be something like drift per second, but not sure how to implement that easily
just from the buffer timestamps. One could calculate a running average of
buffer durations (as calculated from timestamps) probably and base it on that.

@@ +247,3 @@
+    highrand = g_rand_int_range (rand, highmin, highmax);
+    lowrand = g_rand_int (rand);
+    return ((((gint64) highrand) << 32) | lowrand);

This does not allow to get a range between e.g. [2**32, and 2**32 + 5]. Best to
take the code from GLib here and adjust the types

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.