[Bug 787442] kms: set buffer to NULL if allocation failed

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Sep 8 13:02:42 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=787442

--- Comment #1 from Guillaume Desmottes <gdesmott at gnome.org> ---
Created attachment 359399
  --> https://bugzilla.gnome.org/attachment.cgi?id=359399&action=edit
kms: set buffer to NULL if allocation failed

If bo allocation failed we destroy the buffer and return GST_FLOW_ERROR,
but the @buffer pointer was still pointing to the address of the
destroyed buffer. gst_kms_sink_copy_to_dumb_buffer() was then trying to
unref it when bailing out causing a crash.

Best to return NULL rather than an invalid pointer if the allocation
failed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list