[Bug 787442] kms: set buffer to NULL if allocation failed

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Sep 8 13:12:17 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=787442

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #359399|none                        |needs-work
             status|                            |

--- Comment #3 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 359399:
 --> (https://bugzilla.gnome.org/review?bug=787442&attachment=359399)

While at it, can you fix the other code. gst_kms_sink_copy_to_dumb_buffer()
does not initialize buf, and assuming that gst_buffer_pool_acquire_buffer()
have set it to NULL is wrong there (just like assuming it was left untouched,
but this is cleaner to do so of course.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list