[Bug 787311] vtenc: leaks frames when shut down before EOS

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787311

--- Comment #4 from Nicola <lists at svrinformatica.it> ---
well if you set the pipeline to NULL whithout sending an EOS I think is
expected to drop all remaining buffers, I think other elements use this same
logic, but I could be wrong

::finish is already handled, 

actually:

1) if you send an EOS gst_vtenc_finish_encoding is called and the remaining
buffers are forwarded downstream
2) if you set the pipeline to NULL (in my case I streaming and I can set the
pipeline to NULL for example for a network error) gst_vtenc_stop is called and
any remaining buffer is leaked
3) with this patch if you set the pipeline to NULL any remaining buffer is
dropped and no leak happen

based on the docs here:

https://gstreamer.freedesktop.org/data/doc/gstreamer/head/gst-plugins-base-libs/html/gst-plugins-base-libs-GstVideoEncoder.html

- reset is deprecated
- flush will drop the buffers anyway
- finish is handled but is relevant only if you send an EOS

please let me know if you prefer an alternative approach

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.