[Bug 786740] appsink: should not keep a ref on the preroll buffer if belongs to a pool

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Sep 12 13:21:09 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=786740

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358668|none                        |accepted-commit_now
             status|                            |

--- Comment #15 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 358668:
 --> (https://bugzilla.gnome.org/review?bug=786740&attachment=358668)

I think it's better this way, the old behaviour seems unexpected. Can we also
rename ->preroll into ->preroll_buffer ? Looks like a boolean otherwise.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list