[Bug 784599] kmssink: support videooverlay interface

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784599

--- Comment #70 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 359612:
 --> (https://bugzilla.gnome.org/review?bug=784599&attachment=359612)

Just a note that the patch does not apply cleanly on git master.

::: sys/kms/gstkmssink.c
@@ +102,3 @@
+      width = self->hdisplay;
+      height = self->vdisplay;
+      goto commit;

You could avoid the goto here, and it would be nicer. Just check of -1, fix the
width / height. And then check again if it's smaller/equal to zero and return.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.