[Bug 786740] appsink: should not keep a ref on the preroll buffer if belongs to a pool

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Sep 13 13:18:24 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=786740

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358668|accepted-commit_now         |committed
             status|                            |

--- Comment #17 from Julien Isorce <julien.isorce at gmail.com> ---
Comment on attachment 358668
  --> https://bugzilla.gnome.org/attachment.cgi?id=358668
appsink: unref preroll buffer upon pull

commit 68518acb53d4808cf8352ed4fd1cb8b331553559
Author: Julien Isorce <jisorce at oblong.com>
Date:   Tue Aug 29 09:47:51 2017 +0100

    appsink: unref preroll buffer upon pull

    There is no reason for appsink to hang onto the preroll buffer.
    If needed, the application can just keep a ref on this buffer
    after calling gst_app_sink_try_pull_preroll.

    Also added unit test 'test_pull_preroll'
      make elements/appsink.check

    https://bugzilla.gnome.org/show_bug.cgi?id=786740

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list