[Bug 768794] ion: DMA Buf allocator based on ion

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=768794

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #359689|none                        |reviewed
             status|                            |

--- Comment #44 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 359689:
 --> (https://bugzilla.gnome.org/review?bug=768794&attachment=359689)

::: gst-libs/gst/allocators/gstionmemory.c
@@ +84,3 @@
+  };
+
+  ret = ioctl(self->fd, ION_IOC_CUSTOM, &custom);

CUSTOM like in only specific drivers implements this ? If so, shall be ifdef
this with some platform check ? Physical address in userland is a pretty bad
idea in general (with all the security related issues that comes with it). For
this reason, I don't particularly like the idea of sponsoring this idea in
GStreamer final APIs. I think your patch need a long explanation in the
description here at least before it could be considered.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.