[Bug 786738] ximagesink,xvimagesink: handle drain query

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786738

Julien Isorce <julien.isorce at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |NEW

--- Comment #5 from Julien Isorce <julien.isorce at gmail.com> ---
Sorry I should have mentioned that this is when used with gst-omx. This is
mostly due to GstOMXBufferPool which steal buffers from downstream for the
OMX_UseBuffer/UseEGLImage cases
https://cgit.freedesktop.org/gstreamer/gst-omx/tree/omx/gstomxbufferpool.c#n355
.
The attached patches are to honor the drain query sent from:
https://cgit.freedesktop.org/gstreamer/gst-omx/tree/omx/gstomxvideodec.c#n1723
Same thing was done for glimagesink few years ago.

This can be reproduced with:

GST_OMX_CONFIG_DIR=config/tizonia/ gst-launch-1.0 filesrc
location=dynamic_resolution_change.mkv ! matroskademux ! omxvp8dec !
xvimagesink

It is worth mentioning that ximagesink and ximagesink allow downstream elements
to write directly into the images they have allocated:
https://cgit.freedesktop.org/gstreamer/gst-plugins-base/tree/sys/xvimage/xvimagesink.c#n927

Maybe I should modify the patches to only unref the curr_image if the condition
xvimagesink.c#n927 was true when it has ref that buffer (and if its current
pool is not xvimagesink's pool)

I will provide some logs and tests.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.