[Bug 784002] rtpbin: ntp-sync temporarily causes old timestamps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=784002

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #358853|none                        |needs-work
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 358853:
 --> (https://bugzilla.gnome.org/review?bug=784002&attachment=358853)

::: gst/rtpmanager/gstrtpjitterbuffer.c
@@ +3451,3 @@
+      /* verify that an offset has not caused time stamps to go backwards, if
so
+       * handle by reusing the previous timestamp */
+            if (priv->last_out_time > 0 &&

Please fix up the indentation here :)

Also is it 0 when unset? I would've expected GST_CLOCK_TIME_NONE instead. 0
seems like a valid value. And before it was initialized to -1 (aka
GST_CLOCK_TIME_NONE) but you changed it to 0 instead

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.