[Bug 785733] rtpbin: ntp-sync does no sanity checking for clock sync

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785733

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #359582|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 359582:
 --> (https://bugzilla.gnome.org/review?bug=785733&attachment=359582)

Please explain the sanity checking in the commit message already (which cases
are handled, and why are those invalid?)

Also this changes behaviour in rtpbin. We would now always have the 3s limit,
even if ntp-sync is enabled. Not when using rtspsrc as it works around that,
but when using only rtpbin.

::: gst/rtpmanager/gstrtpbin.c
@@ +1593,3 @@

+       stream_set_ts_offset (bin, ostream, ts_offset, bin->max_ts_offset,
+        4 * GST_MSECOND, TRUE);

Where do these 4ms come from? Maybe make them a #define at the top

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.