[Bug 786740] appsink: should not keep a ref on the preroll buffer if belongs to a pool

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786740

--- Comment #19 from Julien Isorce <julien.isorce at gmail.com> ---
(In reply to Tim-Philipp Müller from comment #18)
> Looking at the commit, why do we clear the preroll buffer only on
> try_pull_preroll() ?

Looking at the code in gstappsink.c we do clear it in the following places:
- GST_EVENT_FLUSH_STOP
- basesink_class->stop
- gobject_class->dispose
- try_pull_preroll

> Shouldn't we also clear it if no one actually cares about the preroll buffer?

I like this idea. But it does not look trivial to me to implement the condition
"no one cares" because the user can still call gst_app_sink_pull_preroll even
if he has not set any appsink callbacks or signals.
I tried a little bit but this does not look good at all.

Feel free to suggest a patch, otherwise let's say there is nothing to do more
here. Thx!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.