[Bug 785733] rtpbin: ntp-sync does no sanity checking for clock sync

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785733

--- Comment #13 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
(In reply to Patrick Radizi from comment #12)
> I only implemented the ntp-sync default behaviour in rtspsrc since I thought
> it was the only user of this rtpbin feature. Are there other rtpbin/ntp-sync
> users?

Every application using rtpbin directly and setting that property. At least for
myself I know that I did this a few times in the past.

> If there are I could add the same logic in rtpbin as in rtspsrc and then
> only set max-ts-offset from rtspsrc if it differs from the value in rtpbin
> (since it has side affects)

Ack

> The 4 ms comes from the original code, and was only applied to the non
> ntp-sync case. Why, I don't know but I kept it to not change the behaviour.
> I can add a define for it.

Yeah, just add a #define for that and put the comment (the stuff about NTP/RTP
timestamp rounding errors) next to the #define :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.