[Bug 770934] rtsp: Make RTSP TIMEOUT in RTP/RTSP/TCP transport deterministic

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=770934

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #346810|none                        |reviewed
             status|                            |

--- Comment #31 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 346810
  --> https://bugzilla.gnome.org/attachment.cgi?id=346810
New solution plugins base - update 1

>--- a/gst-libs/gst/rtsp/gstrtspconnection.c
>+++ b/gst-libs/gst/rtsp/gstrtspconnection.c

>+#include <netinet/tcp.h>

Is this include still needed?


>+/**
>+ * gst_rtsp_watch_set_connloss_detect:
>+ * @watch: a #GstRTSPWatch
>+ * @use_connloss_detect: use conncloss detection
>+ *
>+ * When @use_connloss_detect is %TRUE, an early connection loss detection
>+ * is used. This is needed to exactly time the RTSP timeout in higher layers.
>+ *
>+ * Since: 1.11
>+ */

Please update to 1.14 :)



>diff --git a/gst-libs/gst/rtsp/gstrtspconnection.h b/gst-libs/gst/rtsp/gstrtspconnection.h
>index 43479ae..b0e116c 100644
>--- a/gst-libs/gst/rtsp/gstrtspconnection.h
>+++ b/gst-libs/gst/rtsp/gstrtspconnection.h
>@@ -171,6 +171,9 @@ typedef struct _GstRTSPWatch GstRTSPWatch;
>  * @tunnel_http_response: callback when an HTTP response to the GET request
>  *   is about to be sent for a tunneled connection. The response can be
>  *   modified in the callback. Since 1.4.
>+ * @connloss_status: Callback when sending rtp/rtcp over TCP to send back the
>+ *   result of the socket send operation, indication actual loss of connection,
>+ *   temporary or otherwise.

Perhaps 'send back the result of the socket send operation' -> 'check the
low-level state of the socket to detect...' or have I got this wrong
conceptually?

Also please add a Since marker: "...or otherwise. (Since: 1.14)"



>+
>+void               gst_rtsp_watch_set_connloss_detect (GstRTSPWatch * watch,
>+                                                      gboolean use_connloss_detect);

I'm afraid this needs to be updated for git master, needs to have a GST_EXPORT
decorator, and should also be in the .def (make upate-exports) and in the docs
(docs/libs/...-sections.txt).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.