[Bug 786321] vaapi encoder: support bitrate reconfiguration in runtime

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786321

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #359832|none                        |reviewed
             status|                            |

--- Comment #11 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 359832:
 --> (https://bugzilla.gnome.org/review?bug=786321&attachment=359832)

::: gst/vaapi/gstvaapiencode.c
@@ +182,3 @@
+    if (prop_value) {
+      g_value_copy (value, &prop_value->value);
+      return TRUE;

I'm not sure about this.

If I understand this correctly, we might copy the property value either whether
the internal encoder is instantiated or not.

Consider if the internal encoder shall be reconfigured, it will set the initial
values.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.