[Bug 787719] v4l2radio: add signal strength property

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=787719

Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #359843|none                        |needs-work
             status|                            |

--- Comment #2 from Nicolas Dufresne (stormer) <nicolas at ndufresne.ca> ---
Review of attachment 359843:
 --> (https://bugzilla.gnome.org/review?bug=787719&attachment=359843)

::: sys/v4l2/gstv4l2radio.c
@@ +62,3 @@
   ARG_DEVICE,
+  ARG_FREQUENCY,
+  ARG_SIGNAL_STRENGTH

That's nice, you added an enum, but it won't show up if you don't call
g_object_class_install_property() in the class init. Did you tested your patch
?

@@ +483,3 @@
       }
       break;
+    case ARG_SIGNAL_STRENGTH:

Some GST_OBJECT_LOCK() all over maybe ? Can you really set the signal strenght
? What those it means ?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.