[Bug 786321] vaapi encoder: support bitrate reconfiguration in runtime

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=786321

--- Comment #15 from Hyunjun Ko <zzoon at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #11)
> Review of attachment 359832 [details] [review]:
> 
> ::: gst/vaapi/gstvaapiencode.c
> @@ +182,3 @@
> +    if (prop_value) {
> +      g_value_copy (value, &prop_value->value);
> +      return TRUE;
> 
> I'm not sure about this.
> 
> If I understand this correctly, we might copy the property value either
> whether the internal encoder is instantiated or not.
> 
> Consider if the internal encoder shall be reconfigured, it will set the
> initial values.

If I understand what you mean correctly, we can take flush method in encoder
for example.
Every time the internal encoder is recreated, plugin(vaapiencode) calls
ensure_encoder, which is doing set property with its own value (not default).

Note that gst_vaapiencode_default_set_property is not called during this time.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.