[Bug 787820] glvideomixer: need update output geo after src caps reconfigure

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Sep 18 11:11:56 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=787820

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #359963|none                        |needs-work
             status|                            |

--- Comment #2 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 359963:
 --> (https://bugzilla.gnome.org/review?bug=787820&attachment=359963)

Hmm, I suspect that the gst_structure_fixate_field_nearest_int() this will then
fail on:

videotestsrc ! video/x-raw,width=320,height=240 ! glvideomixer !
video/x-raw(ANY),width=800,height=600 ! fakesink

which is a behaviour change.  If we want to chagne it, we also need to change
the compositor element.

::: ext/gl/gstglvideomixer.c
@@ +1081,3 @@
     }
   }
+  mix->output_geo_changed = TRUE;

This should be in the GstGLMixerClass::set_caps() implementation.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list