[Bug 787820] glvideomixer: need update output geo after src caps reconfigure

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Sep 20 11:56:36 UTC 2017


https://bugzilla.gnome.org/show_bug.cgi?id=787820

--- Comment #21 from Haihua Hu <jared.hu at nxp.com> ---
(In reply to Matthew Waters (ystreet00) from comment #20)
> Created attachment 360103 [details]
> glvideomixer-dynamic-input-master log

I setup a latest environment for master, seems that output caps can change as
we think. But glvideomixer has issue when compositor, as we talk above, when
aggregator, glvideomixer will only update output geometry when pad geometry
changed or the first time to call gst_gl_video_mixer_callback

see below code, when caps changed, this will not been called:
1491     if (pad->geometry_change || !pad->vertex_buffer) {
.....
1502       /* top-left */
1503       v_vertices[0] = v_vertices[15] =
1504           2.0f * (gfloat) pad->xpos / (gfloat) out_width - 1.0f;
1505       /* bottom-left */
1506       v_vertices[1] = v_vertices[6] =
1507           2.0f * (gfloat) pad->ypos / (gfloat) out_height - 1.0f;
1508       /* top-right */
1509       v_vertices[5] = v_vertices[10] = v_vertices[0] + 2.0f * w;
1510       /* bottom-right */
1511       v_vertices[11] = v_vertices[16] = v_vertices[1] + 2.0f * h;
.....
}

-- 
You are receiving this mail because:
You are the QA Contact for the bug.


More information about the gstreamer-bugs mailing list