[Bug 781776] decklink: Detect gaps on incoming stream times, issue warnings

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=781776

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #353815|none                        |needs-work
             status|                            |

--- Comment #14 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 353815:
 --> (https://bugzilla.gnome.org/review?bug=781776&attachment=353815)

::: sys/decklink/gstdecklinkaudiosrc.cpp
@@ +690,3 @@
+    if (self->expected_stream_time != GST_CLOCK_TIME_NONE &&
+        ABSDIFF (self->expected_stream_time, p.stream_timestamp) >
+        gst_util_uint64_scale (2, GST_SECOND, self->info.rate)) {

2 samples? Why not > 1?

::: sys/decklink/gstdecklinkvideosrc.cpp
@@ +803,3 @@
   }

+  self->processed += f.stream_duration;

This and the other counter accumulate duration rounding errors

@@ +805,3 @@
+  self->processed += f.stream_duration;
+  if (self->expected_stream_time != GST_CLOCK_TIME_NONE &&
+      ABSDIFF (self->expected_stream_time, f.stream_timestamp) > 1) {

1ns seems dangerous, are you sure? There might be rounding errors with the
duration.

Maybe > 1/fps?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.